Skip to content

Fix PyShp's CI, dropping actions/setup-python, running build.yml Action in Python Docker containers. #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 20, 2024

Conversation

JamesParrott
Copy link
Collaborator

This is trickier to test than normal, as as far as I can tell Github actions are only run from the master branch (and I've renamed master to main in my fork). There might be some other bug or subtlety I've missed, but in my fork's main branch I've got the same build.yml file, only targetting the branch from which this PR is coming (in which build.yml targets master).

This PR is from a branch based on the branch from which I raised my previous PR, #265 so it includes the blocking out of the failing Doctest. the test results for PyShp are all green on Pythons 2.7, 3.5, ..., 3.9.
image
https://github.com/JamesParrott/IronPyShp/actions/runs/7545262680/job/20540473529

Summary of changes:

  • Drop actions/setup-python, move the matrix strategy forward, pin to the specific patch versions below, and use the matrix to run the action in Python Slim containers (versions 2.7.18, 3.5.10, 3.6.15, 3.7.17, 3.8.18, and 3.9.18)
  • Bump actions/checkout from v2 to v3
  • Reformat PyShp usage example with undefined variable in readme.md from >>> to Markdown code literal block, so doctest skips it, as for PR # 265.
  • Don't track my VS Code settings files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants