Failed test fixes #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def test_process(self): | ||
| raster = utils.polygons_to_raster(self.testfile, "GeoID", **self.kwargs) | ||
| raster = utils.polygons_to_raster(self.testfile, "GeoID") |
There was a problem hiding this comment.
This looses the cellsize argument that is needed.
There was a problem hiding this comment.
Right, instead the function defaults to a cellsize of 4. I'll see if there's another way to get around the error it was throwing.
There was a problem hiding this comment.
We need to find one. The point of the tests is to check different cell sizes. This throws 3 failures for me,
…olygons_to_raster_mixin.test_process so cellsize is passed properly (closes #44); stripped parameter names off tidegates.flood_area call in StandardScenarios.analyze because they were causing inexplicable TypeError (mentioned in #37); fixed Extension class not checking extension back in when finishing.
This was referenced Nov 17, 2015
…narios.analyze because the problem seems to have been resolved.
phobson
added a commit
that referenced
this pull request
Nov 17, 2015
fixed Extension context manager, skip more tests
This was referenced Nov 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some issues raised in #18.