Merge pull request madler#6 from ClickHouse-Extras/backport-x86-arm-c…

…heck-features-constructor Backport Check for x86 features when the library is loaded.
GerHobbelt · Apr 15, 2021 · 16b42c7 · 16b42c7
2 parents 527425a + 9dd963a
commit 16b42c7
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 20 deletions.
diff --git a/arch/arm/arm.h b/arch/arm/arm.h
@@ -15,6 +15,4 @@ void dummy_linker_glue();
 extern int arm_cpu_has_neon;
 extern int arm_cpu_has_crc32;
 
-void Z_INTERNAL arm_check_features(void);
-
 #endif /* ARM_H_ */
diff --git a/arch/arm/armfeature.c b/arch/arm/armfeature.c
@@ -61,7 +61,7 @@ static inline int arm_has_neon() {
 Z_INTERNAL int arm_cpu_has_neon;
 Z_INTERNAL int arm_cpu_has_crc32;
 
-void Z_INTERNAL arm_check_features(void) {
+static void __attribute__((constructor)) arm_check_features(void) {
 #if defined(__aarch64__) || defined(_M_ARM64)
     arm_cpu_has_neon = 1; /* always available */
 #else

diff --git a/arch/x86/x86.c b/arch/x86/x86.c
@@ -52,9 +52,9 @@ static void cpuidex(int info, int subinfo, unsigned* eax, unsigned* ebx, unsigne
 #endif
 }
 
-void Z_INTERNAL x86_check_features(void) {
-    unsigned eax, ebx, ecx, edx;
-    unsigned maxbasic;
+static void __attribute__((constructor)) x86_check_features(void) {
+	unsigned eax, ebx, ecx, edx;
+	unsigned maxbasic;
 
     cpuid(0, &maxbasic, &ebx, &ecx, &edx);
 

diff --git a/arch/x86/x86.h b/arch/x86/x86.h
@@ -13,6 +13,4 @@ extern int x86_cpu_has_sse42;
 extern int x86_cpu_has_pclmulqdq;
 extern int x86_cpu_has_tzcnt;
 
-void Z_INTERNAL x86_check_features(void);
-
 #endif /* CPU_H_ */
diff --git a/deflate.c b/deflate.c
@@ -259,12 +259,6 @@ int32_t Z_EXPORT PREFIX(deflateInit2_)(PREFIX3(stream) *strm, int32_t level, int
     int wrap = 1;
     static const char my_version[] = PREFIX2(VERSION);
 
-#if defined(X86_FEATURES)
-    x86_check_features();
-#elif defined(ARM_FEATURES)
-    arm_check_features();
-#endif
-
     if (version == NULL || version[0] != my_version[0] || stream_size != sizeof(PREFIX3(stream))) {
         return Z_VERSION_ERROR;
     }

diff --git a/inflate.c b/inflate.c
@@ -132,12 +132,6 @@ int32_t Z_EXPORT PREFIX(inflateInit2_)(PREFIX3(stream) *strm, int32_t windowBits
     int32_t ret;
     struct inflate_state *state;
 
-#if defined(X86_FEATURES)
-    x86_check_features();
-#elif defined(ARM_FEATURES)
-    arm_check_features();
-#endif
-
     if (version == NULL || version[0] != PREFIX2(VERSION)[0] || stream_size != (int)(sizeof(PREFIX3(stream))))
         return Z_VERSION_ERROR;
     if (strm == NULL)