certain games crash explorer when moused over or selected #195
Comments
|
This indicates a bug with the metadata handler that was added in v1.4. I don't have a copy of this game offhand; I'll get a copy and see if I can reproduce this issue. |
|
Reproduced this on Windows 7, but not on KDE. (Though KDE isn't showing the disc image metadata for some reason...) |
GerbilSoft
added a commit
that referenced
this issue
Sep 17, 2019
…alue. We'll just add a nullptr string. TODO: Skip the property entirely? An empty string isn't expected here, and that usually indicates something's wrong. Added an assert() for debug builds. [kde, win32] Handle nullptr strings by not adding the property. This fixes issue #195: certain games crash explorer when moused over or selected. Well, at least it fixes the crash; the underlying issue is in the GameCubeBNR parser, and that needs to be fixed.
GerbilSoft
added a commit
that referenced
this issue
Sep 17, 2019
…ame error. This was the underlying cause of the crash in issue #195. Prince of Persia: The Sands of Time has an empty "full" game name. We checked that first, saw it was empty, then went to the regular game name. That one isn't empty, but due to a copy/paste error, the full game name was still used, resulting in an empty entry.
|
Fixed in master; will cherry-pick this fix (and a fix for some Xbox 360 games) into the 1.4 branch and release v1.4.2. |
GerbilSoft
added a commit
that referenced
this issue
Sep 17, 2019
…alue. We'll just add a nullptr string. TODO: Skip the property entirely? An empty string isn't expected here, and that usually indicates something's wrong. Added an assert() for debug builds. [kde, win32] Handle nullptr strings by not adding the property. This fixes issue #195: certain games crash explorer when moused over or selected. Well, at least it fixes the crash; the underlying issue is in the GameCubeBNR parser, and that needs to be fixed. (cherry picked from commit d231895)
GerbilSoft
added a commit
that referenced
this issue
Sep 17, 2019
…ame error. This was the underlying cause of the crash in issue #195. Prince of Persia: The Sands of Time has an empty "full" game name. We checked that first, saw it was empty, then went to the regular game name. That one isn't empty, but due to a copy/paste error, the full game name was still used, resulting in an empty entry. (cherry picked from commit 9cf708f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
prince of persia: sands of time for gamecube is one example
The text was updated successfully, but these errors were encountered: