Skip to content

fix: Implement validation for extension_data field in FRProject #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Implement validation for extension_data field in FRProject #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pmp_manip/core/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,9 @@ def __post_init__(self) -> None:
Returns:
None
"""
# TODO #if self.extension_data != {}: raise MANIP_ThanksError() # also uncomment test
if self.extension_data != {}:
from pmp_manip.utility import MANIP_ThanksError
raise MANIP_ThanksError()

@enforce_argument_types
def add_all_extensions_to_info_api(self, info_api: OpcodeInfoAPI) -> None:
Expand Down
93 changes: 87 additions & 6 deletions tests/core/test_project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,93 @@ def test_FRProject_from_file():


def test_FRProject_post_init():
... # TODO
#with raises(MANIP_ThanksError):
# FRProject.from_data(
# data=PROJECT_DATA | {"extensionData": 7},
# asset_files=PROJECT_ASSET_FILES,
# )
from pytest import raises
from pmp_manip.utility import MANIP_ThanksError
from pmp_manip.core.meta import FRMeta
from pmp_manip.core.target import FRStage, FRSprite

# Create a minimal stage and sprite data based on the original PROJECT_DATA structure
minimal_stage_data = {
"isStage": True,
"name": "_stage_",
"variables": [],
"lists": [],
"broadcasts": [],
"blocks": {},
"comments": {},
"currentCostume": 0,
"costumes": [{
"assetId": "cd21514d0531fdffb22204e0ec5ed84a",
"name": "backdrop1",
"bitmapResolution": 1,
"md5ext": "cd21514d0531fdffb22204e0ec5ed84a.svg",
"dataFormat": "svg",
"rotationCenterX": 240,
"rotationCenterY": 180
}],
"sounds": [],
"volume": 100,
"layerOrder": 0,
"tempo": 60,
"videoTransparency": 50,
"videoState": "on",
"textToSpeechLanguage": None
}

minimal_sprite_data = {
"isStage": False,
"name": "Sprite1",
"variables": [],
"lists": [],
"broadcasts": [],
"blocks": {},
"comments": {},
"currentCostume": 0,
"costumes": [{
"assetId": "c434b674f2da18ba13cdfe51dbc05ecc",
"name": "costume1",
"bitmapResolution": 1,
"md5ext": "c434b674f2da18ba13cdfe51dbc05ecc.svg",
"dataFormat": "svg",
"rotationCenterX": 47,
"rotationCenterY": 55
}],
"sounds": [],
"volume": 100,
"layerOrder": 1,
"visible": True,
"x": 0,
"y": 0,
"size": 100,
"direction": 90,
"draggable": False,
"rotationStyle": "normal"
}

minimal_data = {
"targets": [minimal_stage_data, minimal_sprite_data],
"monitors": [],
"extensionData": 7, # This should trigger the error
"extensions": [],
"extensionURLs": {},
"meta": {
"semver": "3.0.0",
"vm": "0.2.0",
"agent": "",
"platform": {
"name": "PenguinMod",
"url": "https://penguinmod.com/",
"version": "stable",
},
}
}

asset_files = {}
with raises(MANIP_ThanksError):
FRProject.from_data(
data=minimal_data,
asset_files=asset_files,
)


def test_FRProject_add_all_extensions_to_info_api(monkeypatch: MonkeyPatch):
Expand Down