Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal Error in combination with EXT:flux #585

Closed
rfuehricht opened this issue Sep 5, 2023 · 5 comments
Closed

Fatal Error in combination with EXT:flux #585

rfuehricht opened this issue Sep 5, 2023 · 5 comments

Comments

@rfuehricht
Copy link

Hi!

I asked in EXT:flux for help but it seems that this might rather be an issue in EXT:mask (see: FluidTYPO3/flux#2132).

When editing a content element, this error is shown:

Screenshot 2023-09-05 at 15 04 57

Mask introduces two itemsProcFuncs and calls previously set itemsProcFuncs using this code:

GeneralUtility::callUserFunction( $params['config']['m_itemsProcFunc'], $params, $this );

As stated in the issue I created for EXT:flux, the third parameter should not be $this, but rather the parent object calling the itemsProcFunc.

So, I propose to add a second parameter to the itemsProcFunc an pass it in the callUserFunctioncall:

public function itemsProcFunc(&$params, $parentObj): void
...

GeneralUtility::callUserFunction( $params['config']['m_itemsProcFunc'], $params, $parentObject );

nhovratov added a commit that referenced this issue Sep 5, 2023
@nhovratov
Copy link
Collaborator

Hi, thanks for the issue reporting. Fixed it like you suggested. Will release a new version soon.

@nhovratov
Copy link
Collaborator

@rfuehricht Can you verify, that this fixes the issue for you? I'll wait with the release until I have a "go" from you, as I didn't setup the flux extension in my development environment to test it.

@rfuehricht
Copy link
Author

Hi!

I can confirm, that the fix solves the issue.

Thank you very much.

@nhovratov
Copy link
Collaborator

@rfuehricht Thank you for verifying! Mask 8.3.3 is released now.

@NamelessCoder
Copy link

Thanks for the quick fix @nhovratov ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants