Revert prefix override workaround #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The work-around is no longer needed, as the upstream bug seems to be fixed in atom-languageclient. References #501.
machitgarha
changed the title
|
@Gert-dev Any updates on this one? |
|
Hmm... How can I try this? |
|
For a quick fix, do the steps mentioned in this comment. |
|
Thanks for taking the time to invest this and send this pull request. I haven't used in Atom in quite some time, as I might have implied in some other tickets already, but it's good to see that the community is picking up where Microsoft/GitHub/Facebook left it off. Judging by the various comments in the issues and your post, I'll take your word for that it is now obsolete and merge this. |
|
Thanks for your confidence. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the upstream bug in atom-languageclient no longer exists (after the transition from atom into atom-ide-community), so the workaround for filtering and sorting is no longer needed. As I tested, the extension works perfectly with this change (i.e. without the workaround).
Closes #501 and #485. Should close #489 as well.