fixing git #4
Open
fixing git #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs dal_queryset_sequence proposal.
The section "Filtering results based on the value of other fields in the form" had some small errors in the sample code.
Update tutorial.rst
TaggitSelect2: insure there's a comma when there's only one tag, or tag "Multi word" would end up as "Multi" and "word"
…get (yourlabs#743) * Correctly show an empty option tag when a placeholder is specified, which is what the select2 library expects by design, which fixes the placeholder not used when the widget is supplied with a list of choices but no external datasource URL. * Add test case for Select2 widget option rendering when not using a URL * Fix import ordering to fix tox warning * Reduce line length to fix tox warning * Add note about setting a placeholder generating an empty option tag
* Fixed integration with django js i18n https://docs.djangoproject.com/en/1.10/topics/i18n/translation/#internationalization-in-javascript-code DAL breaks with i18n * Adding Italo Maia to authors
…labs#821) -Made select2ListView return a case insensitive match by default to match the select2QueryView -Added unit test for the case insensitivity
Change from the default 79 to 88.
Still in the index, but not .gitmodules anymore.
There was a broken entry
Get the browser based tests working on travisci again. Splinter deprecated phantomjs, so switch to headless firefox. Upgrade the travisci environment to unbuntu xenial (geckodriver fails in default trusty, easier to do this then figure out the real problem with the geckodriver/firefox/selenium versions). Also add python 3.6 test run, since 3.5 fails (unrelated to the browers based test) and we atleast get a green checkmark from travis to show it can work.
The 'global' test browser is never closed. Pytest-splinter is already in the project, so let's use its session scoped browser, which nicely closes itself after the test session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.