This repository has been archived by the owner on Apr 7, 2024. It is now read-only.
Fix uploaded_resources directory permissions #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafeder
reviewed
Feb 17, 2022
Comment on lines
+30
to
33
| ->exec('chmod -R 777 sites/default/files') | ||
| // Workaround for https://www.drupal.org/project/drupal/issues/3091285. | ||
| ->exec('chmod u+w sites/default') | ||
| ->dir(Util::getProjectDocroot()) |
There was a problem hiding this comment.
@clayliddell aren't these two lines redundant?
There was a problem hiding this comment.
No, the second line just affects sites/default since it's non-recursive. The first line is recursive and targets all files and folders within sites/default/files.
There was a problem hiding this comment.
I know, I just was thinking they could be combined but I can see how it might cast too wide a net to just 777 the whole default folder. OK will merge after testing
There was a problem hiding this comment.
There's a few settings files in the sites/default directory which are read-only for non-owners by default, and I think it would probably be best to leave them that way:
$ ls -al
drwxr-xr-x 3 clayliddell clayliddell 4096 Feb 17 13:48 .
drwxr-xr-x 11 clayliddell clayliddell 4096 Feb 17 13:48 ..
-rw-r--r-- 1 clayliddell clayliddell 7565 Feb 17 13:48 default.services.yml
-rw-r--r-- 1 clayliddell clayliddell 32852 Feb 17 13:48 default.settings.php
drwxrwxrwx 7 clayliddell clayliddell 4096 Feb 17 13:50 files
-rw-r--r-- 1 clayliddell clayliddell 682 Feb 17 13:46 settings.docker.php
-r--r--r-- 1 clayliddell clayliddell 403 Feb 17 13:46 settings.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA Instructions