Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JSON icon for GeoJSON format #2288

Merged
merged 4 commits into from
Dec 19, 2017
Merged

Use JSON icon for GeoJSON format #2288

merged 4 commits into from
Dec 19, 2017

Conversation

dafeder
Copy link
Member

@dafeder dafeder commented Dec 19, 2017 •
edited by janette
Loading

Change the icon used for GeoJSON resources in the dataset resource list. We should add a special GeoJSON icon but for now, let's at least use the JSON icon rather than defaulting to "Data".

QA Steps

dkan

Reminders

  • There is test for the issue.
  • CHANGELOG updated.
  • Coding standards checked.
  • Review docs.getdkan.com (or in /docs) to see if it still covers the scope of the PR and update if needed.

@dafeder dafeder requested a review from janette December 19, 2017 16:48
@janette janette merged commit 3cb88f7 into 7.x-1.x Dec 19, 2017
@fmizzell fmizzell deleted the json-geojson-icon branch January 4, 2018 20:35
dafeder added a commit that referenced this pull request Apr 24, 2020
@dafeder @janette
Use JSON icon for GeoJSON format (#2288)
dc6487c 
* Use JSON icon for GeoJSON format

* Update CHANGELOG.txt

* Update dkan_dataset.css

* Update css for geojson icon
dafeder added a commit that referenced this pull request Apr 24, 2020
@dafeder @janette
Use JSON icon for GeoJSON format (#2288)
1bd37f4 
* Use JSON icon for GeoJSON format

* Update CHANGELOG.txt

* Update dkan_dataset.css

* Update css for geojson icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janette janette Awaiting requested review from janette

Assignees
No one assigned
Labels
Component: Nuboot_Radix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dafeder @janette