Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch features to add new line after <?php #2370

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Patch features to add new line after <?php #2370

merged 1 commit into from
Feb 12, 2018

Conversation

dafeder
Copy link
Member

@dafeder dafeder commented Feb 10, 2018

Coder now asks for a blank line between the initial <?php and any code. This patch to features fixes an issue where any generated feature files fail coder due to this new standard.

This patch was used to re-export the features in this commit: 5d8bd06 , see for example

Copy link
Member

@janette janette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful

@janette janette merged commit dd38e28 into GetDKAN:7.x-1.x Feb 12, 2018
janette pushed a commit that referenced this pull request Feb 16, 2018
* New release replacements on makefiles and info files

* Add custom css to docs (#2293)

* Add custom css to docs

* Change title to DKAN Docs

* Removes version information from all modules .info files.

* Pegs the versions of some external modules in accordance to their new release schemes.

* Fixing linting issues with .info files.

* Remove redundant debug output. (#2332)

* Pin sphinx to 1.5.6 (#2337)

* Add results count to dkan admin views (#2327)

* Add results count to dkan admin views

* Restore blank line on line 2

* Update @resource_all_09 scenario (#2321)

* Moving the "Adding New Content" page to main admin doc tree (#2347)

"Adding New Content" is vital but was previously buried two levels in; page deserves to be accessible in main admin doc tree

* Site Manager Monthly Maintenance checklist (#2345)

See #2313

* Remove out-dated owners.md file

* Updated Help page; can add your company to listing (#2346)

* Updated Help page; can add your company to listing

See #2306

* Adding Kim's comment to the "Add Your Business" page

* Patch features to add new line after <?php (#2370)

* Modifies curl settings so url headers and info can be properly acquired with curl (#2341)

* Modifies curl settings so url headers and info can be properly acquired with curl.

* Fixing linting issues with .info files.

* Update file name on getRemoteFileInfoTest.php

* Update test file

* Upgrade filefield_sources to 1.11 (#2359)

* Changelog for the 1.14.2 patch release. (#2371)

* Security update for Entity API (#2377)

* Changelog for the 1.14.3 patch release

* Fix linting issues
fmizzell pushed a commit that referenced this pull request Apr 18, 2018
* New release replacements on makefiles and info files

* Add custom css to docs (#2293)

* Add custom css to docs

* Change title to DKAN Docs

* Removes version information from all modules .info files.

* Pegs the versions of some external modules in accordance to their new release schemes.

* Fixing linting issues with .info files.

* Remove redundant debug output. (#2332)

* Pin sphinx to 1.5.6 (#2337)

* Add results count to dkan admin views (#2327)

* Add results count to dkan admin views

* Restore blank line on line 2

* Update @resource_all_09 scenario (#2321)

* Moving the "Adding New Content" page to main admin doc tree (#2347)

"Adding New Content" is vital but was previously buried two levels in; page deserves to be accessible in main admin doc tree

* Site Manager Monthly Maintenance checklist (#2345)

See #2313

* Remove out-dated owners.md file

* Updated Help page; can add your company to listing (#2346)

* Updated Help page; can add your company to listing

See #2306

* Adding Kim's comment to the "Add Your Business" page

* Patch features to add new line after <?php (#2370)

* Modifies curl settings so url headers and info can be properly acquired with curl (#2341)

* Modifies curl settings so url headers and info can be properly acquired with curl.

* Fixing linting issues with .info files.

* Update file name on getRemoteFileInfoTest.php

* Update test file

* Upgrade filefield_sources to 1.11 (#2359)

* Changelog for the 1.14.2 patch release. (#2371)

* Security update for Entity API (#2377)

* Changelog for the 1.14.3 patch release

* Fix linting issues
fmizzell pushed a commit that referenced this pull request Apr 18, 2018
* New release replacements on makefiles and info files

* Add custom css to docs (#2293)

* Add custom css to docs

* Change title to DKAN Docs

* Removes version information from all modules .info files.

* Pegs the versions of some external modules in accordance to their new release schemes.

* Fixing linting issues with .info files.

* Remove redundant debug output. (#2332)

* Pin sphinx to 1.5.6 (#2337)

* Add results count to dkan admin views (#2327)

* Add results count to dkan admin views

* Restore blank line on line 2

* Update @resource_all_09 scenario (#2321)

* Moving the "Adding New Content" page to main admin doc tree (#2347)

"Adding New Content" is vital but was previously buried two levels in; page deserves to be accessible in main admin doc tree

* Site Manager Monthly Maintenance checklist (#2345)

See #2313

* Remove out-dated owners.md file

* Updated Help page; can add your company to listing (#2346)

* Updated Help page; can add your company to listing

See #2306

* Adding Kim's comment to the "Add Your Business" page

* Patch features to add new line after <?php (#2370)

* Modifies curl settings so url headers and info can be properly acquired with curl (#2341)

* Modifies curl settings so url headers and info can be properly acquired with curl.

* Fixing linting issues with .info files.

* Update file name on getRemoteFileInfoTest.php

* Update test file

* Upgrade filefield_sources to 1.11 (#2359)

* Changelog for the 1.14.2 patch release. (#2371)

* Security update for Entity API (#2377)

* Changelog for the 1.14.3 patch release

* Fix linting issues
acouch pushed a commit that referenced this pull request May 7, 2018
* New release replacements on makefiles and info files

* Add custom css to docs (#2293)

* Add custom css to docs

* Change title to DKAN Docs

* Removes version information from all modules .info files.

* Pegs the versions of some external modules in accordance to their new release schemes.

* Fixing linting issues with .info files.

* Remove redundant debug output. (#2332)

* Pin sphinx to 1.5.6 (#2337)

* Add results count to dkan admin views (#2327)

* Add results count to dkan admin views

* Restore blank line on line 2

* Update @resource_all_09 scenario (#2321)

* Moving the "Adding New Content" page to main admin doc tree (#2347)

"Adding New Content" is vital but was previously buried two levels in; page deserves to be accessible in main admin doc tree

* Site Manager Monthly Maintenance checklist (#2345)

See #2313

* Remove out-dated owners.md file

* Updated Help page; can add your company to listing (#2346)

* Updated Help page; can add your company to listing

See #2306

* Adding Kim's comment to the "Add Your Business" page

* Patch features to add new line after <?php (#2370)

* Modifies curl settings so url headers and info can be properly acquired with curl (#2341)

* Modifies curl settings so url headers and info can be properly acquired with curl.

* Fixing linting issues with .info files.

* Update file name on getRemoteFileInfoTest.php

* Update test file

* Upgrade filefield_sources to 1.11 (#2359)

* Changelog for the 1.14.2 patch release. (#2371)

* Security update for Entity API (#2377)

* Changelog for the 1.14.3 patch release

* Fix linting issues
dafeder pushed a commit that referenced this pull request May 11, 2018
* Add Extended Metadata Field for Datasets (#2290)

* Enabled dkan-dataset_paragraphs module

* Added paragraphs, paragraphs_defaults modules

* Added dkan_dataset_paragraphs dependency to dkan.info

* Added changelog

* Added composer_manager to drupal-org.make (#2323)

* Added composer_manager to drupal-org.make

* Updated CHANGELOG

* Revert "Added composer_manager to drupal-org.make (#2323)"

This reverts commit 39e33fe.

* Integration 1.14.3 (#2378)

* New release replacements on makefiles and info files

* Add custom css to docs (#2293)

* Add custom css to docs

* Change title to DKAN Docs

* Removes version information from all modules .info files.

* Pegs the versions of some external modules in accordance to their new release schemes.

* Fixing linting issues with .info files.

* Remove redundant debug output. (#2332)

* Pin sphinx to 1.5.6 (#2337)

* Add results count to dkan admin views (#2327)

* Add results count to dkan admin views

* Restore blank line on line 2

* Update @resource_all_09 scenario (#2321)

* Moving the "Adding New Content" page to main admin doc tree (#2347)

"Adding New Content" is vital but was previously buried two levels in; page deserves to be accessible in main admin doc tree

* Site Manager Monthly Maintenance checklist (#2345)

See #2313

* Remove out-dated owners.md file

* Updated Help page; can add your company to listing (#2346)

* Updated Help page; can add your company to listing

See #2306

* Adding Kim's comment to the "Add Your Business" page

* Patch features to add new line after <?php (#2370)

* Modifies curl settings so url headers and info can be properly acquired with curl (#2341)

* Modifies curl settings so url headers and info can be properly acquired with curl.

* Fixing linting issues with .info files.

* Update file name on getRemoteFileInfoTest.php

* Update test file

* Upgrade filefield_sources to 1.11 (#2359)

* Changelog for the 1.14.2 patch release. (#2371)

* Security update for Entity API (#2377)

* Changelog for the 1.14.3 patch release

* Fix linting issues

* Fixing lint issues with spaces at the end of info files.

*  Allows the services API to be able to consume datasets with the same… (#2409)

*  Allows the services API to be able to consume datasets with the same format given when retrieving a dataset through the API.

* Temporarily disabling unrelated failing tests.

* Updating unittests due to changes in California's open data porta.

* Update CHANGELOG.txt

* Updates config.yml

* Updates config.yml

* Updates config.yml

* Updates config.yml

* Updates config.yml

* Updates config.yml

* Updates config.yml

* Updates config.yml

* Updates config.yml

* Updates config.yml

* Updates config.yml

* Updates config.yml

* Updates config.yml

* Updates config.yml

* Updates config.yml

* Updates config.yml

* Updates docker.ahoy.yml

* Updates config.yml

* Updates config.yml

* Updates config.yml

* Fixme for harvest tests (#2470)

* Updates circle.yml

* Updates circle.yml

* OMT

* readds caching

* readds caching

* readds caching

* Update DkanDatastoreFastImportTest.php

* Update DkanDatastoreFastImportTest.php

* Updates phpunit tests

* Updates test features for dkan 1.15 release

* Update resource.author.feature

* Adds fixme

* Revert "Add Extended Metadata Field for Datasets (#2290)"

This reverts commit 1f8f7c9.

* Remove merge artifact and document commenting out testDataJson().

* Reduce background for recline feature.

* Fix recline feature background

* Add @fixme to two more resource author scenarios
@dafeder dafeder deleted the features-newline-patch branch February 28, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants