Adjust tests to work given client config #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafeder
pushed a commit
that referenced
this pull request
Apr 24, 2020
* Adjust tests to work given client config * Adjust tests to work given client config * Tag tests that exceed 30 second limit * Update panels test to avoid open alert error
dafeder
pushed a commit
that referenced
this pull request
Apr 24, 2020
* Adjust tests to work given client config * Adjust tests to work given client config * Tag tests that exceed 30 second limit * Update panels test to avoid open alert error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dataset_author_7
If a site makes it mandatory for datasets to belong to a group, this test will fail so adding a group assignment to the background.
@dataset_all_8
Existing test assumes the tag will be in the first 20 results for tags. On sites with more than 20 tags, many terms will be hidden in the 'see more' section of the list. Additionally, the results will be listed by the number of times the tag is used and since the test tags will only have one result this also puts them in the 'see more' section of the list even when searching by the term 'health 2'
So revising the test to use terms unlikely to be used on a real site. And filtering to make sure our term is in the top 20 tags displayed.
Timing problem when step takes longer than 30 seconds (rebuilding permissions)
home.feature > Scenario: Rebuild Permissions
topics.feature > Scenario: Rebuild Permissions
workflow.feature > @workflow_23