Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check character length of harvested resource urls #2485

Merged
merged 2 commits into from
May 10, 2018
Merged

Check character length of harvested resource urls #2485

merged 2 commits into from
May 10, 2018

Conversation

janette
Copy link
Member

@janette janette commented May 2, 2018 •
edited
Loading

connects https://github.com/NuCivic/cadepttech/issues/112

Harvest issues with resource files

  • Resources with extremely long urls are not being created due to size limit on the managed file uri field [varchar(255)]

harvest-error

QA Steps

  1. Create harvest source: https://data.cnra.ca.gov/data.json
    filter: identifier = 33f45be7-970c-4d57-b6e1-e20c80b60588
  2. Harvest and confirm all 18 of the resources are created and linked to the dataset
  3. View the harvest error log and confirm there are no errors

dafeder
dafeder approved these changes May 10, 2018
View reviewed changes
Copy link
Member

@dafeder dafeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dafeder dafeder merged commit 7ce6d0b into GetDKAN:7.x-1.x May 10, 2018
@dafeder dafeder removed the Release label May 10, 2018
fmizzell pushed a commit that referenced this pull request May 14, 2018
@janette @fmizzell
Check character length of harvested resource urls (#2485)
55c56cd
dafeder pushed a commit that referenced this pull request Apr 24, 2020
@janette @fmizzell
Check character length of harvested resource urls (#2485)
04e81ff
dafeder pushed a commit that referenced this pull request Apr 24, 2020
@janette @fmizzell
Check character length of harvested resource urls (#2485)
cd6c4ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dafeder dafeder dafeder approved these changes

Assignees

@dafeder dafeder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janette @dafeder