Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the file_resup module to version 1.5. #2492

Merged
merged 1 commit into from
May 5, 2018
Merged

Conversation

fmizzell
Copy link
Contributor

@fmizzell fmizzell commented May 4, 2018

Fixes #2491

@fmizzell fmizzell merged commit f4fcc1d into 7.x-1.x May 5, 2018
@fmizzell fmizzell deleted the file-resup-1.5 branch May 5, 2018 06:24
@elstudio
Copy link

elstudio commented May 7, 2018

Thanks for getting to this so quickly!

One question, though --

Is there a good reason to specify a specific git commit hash in the make file rather than simply version 1.5?

Using the plain version number makes Drupal's updates screen much clearer -- that way we all know this is the plain-vanilla file_resup-7.x-1.5 from HEAD rather than some special version.

(Had we been on v1.4 previously, I would have submitted a pull request and spared you a little bit of work.)

@fmizzell
Copy link
Contributor Author

fmizzell commented May 7, 2018

@elstudio That is a good question. I will ask around, and if there isn't a particular reason, we will do exactly what you suggest. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants