Updates docker-compose to use updated cli container #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafeder
pushed a commit
that referenced
this pull request
Apr 24, 2020
* Updates to our own container * Updates enabling xdebug * Fixes artifacts * Updates config * Update config.yml
dafeder
pushed a commit
that referenced
this pull request
Apr 24, 2020
* Updates to our own container * Updates enabling xdebug * Fixes artifacts * Updates config * Update config.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current cli container is extremely old (ubuntu 12.04). This updates to 16.04 and sets the cli memory to unlimited.
This also has a couple of small updates to keep xdebug working. Xdebug is off by default but
ahoy docker xdebug startshould start xdebug..The new cli container lives here: https://github.com/GetDKAN/dkan-docker/tree/master/.docker/php5-cli and is available in docker hub as
getdkan/dkan-docker:php5-cliAcceptance criteria
ahoy docker uplocallyahoy cmd-proxy "php -i | grep memory"and see memory is unlimitedahoy cmd-proxy "php -i | grep xdebug"and see xdebug is off by defaultahoy docker xdebug startandahoy cmd-proxy "php -i | grep xdebug"and see xdebug is onahoy docker xdebug stopahoy cmd-proxy "php -i | grep memory"and see xdebug is off again