Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Data API table documentation tweaks #2572

Merged

Conversation

rhabbachi
Copy link
Contributor

@rhabbachi rhabbachi commented Jun 20, 2018

We worked on data.json mapping documentation for a partner today and as part of the work we had to define the mapping between DKAN user facing field label and data.json properties.

The PR includes:

  • Small fix on the title pod link (first link of the first table).
  • Update POD links to point to the v1.1 documentations.
  • Add DKAN field labels.
  • Add missing field_conforms_to to the dataset fields table.

Reminders

  • There is test for the issue.
  • Coding standards checked.
  • Review docs.getdkan.com (or in /docs) to see if it still covers the scope of the PR and update if needed.


"", , "dcat:accessURL", "accessURL"
"", , "dct:conformsTo", "conformsTo"
"", , "", "describedBy",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhabbachi I think the last comma on 73 is adding an extra column

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep fixed. Good catch!

@janette janette merged commit 2be9fde into GetDKAN:7.x-1.x Jun 21, 2018
@janette
Copy link
Member

janette commented Jun 21, 2018

Thanks @rhabbachi !

dafeder pushed a commit that referenced this pull request Apr 24, 2020
* Fix data.json POD title link

* Add DKAN field labels to data.json mapping tables

* Add field_conforms_to the data.json documentation
dafeder pushed a commit that referenced this pull request Apr 24, 2020
* Fix data.json POD title link

* Add DKAN field labels to data.json mapping tables

* Add field_conforms_to the data.json documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants