Add new curl function to limit how much of the file is returned #2599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is similar to previous code #1590 |
fmizzell
suggested changes
Aug 2, 2018
| @@ -163,7 +197,7 @@ private function getFileInfoHelper($url, $no_body = TRUE) { | |||
| curl_setopt($ch, CURLOPT_NOBODY, 1); | |||
| } | |||
| curl_setopt($ch, CURLOPT_FOLLOWLOCATION, TRUE); | |||
| curl_setopt($ch, CURLOPT_HTTPHEADER, array("Range: bytes=0-1000")); | |||
| //curl_setopt($ch, CURLOPT_HTTPHEADER, array("Range: bytes=0-1000")); Not Effective. | |||
There was a problem hiding this comment.
Since this is not working, lets go ahead an remove it.
|
ok back to you @fmizzell |
dafeder
pushed a commit
that referenced
this pull request
Apr 24, 2020
dafeder
pushed a commit
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects https://github.com/NuCivic/healthdata/issues/1062
Recap
When running
$info = $this->getFileInfoHelper($url, FALSE)the content of the file is copied in full ascurl_setopt($ch, CURLOPT_RANGE, '0-1000');is not honored.This causes out of memory errors when harvesting.
Creating a second helper function to run if
$info = $this->getFileInfoHelper($url, TRUE)does not return the headers we need.QA Steps
drush dkan-h data_cdc_gov