Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out dkan-tools with ddev-addon. #3846

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Swap out dkan-tools with ddev-addon. #3846

merged 2 commits into from
Feb 21, 2023

Conversation

janette
Copy link
Member

@janette janette commented Oct 7, 2022

fixes [org/repo/issue#]

  • Test coverage exists
  • Documentation exists

QA Steps

  • Add manual QA steps in checklist format for a reviewer to perform to confirm that the feature or fix is working. Include as much details as possible so that the reviewer doesn't lose time figuring out how to perform steps.

@janette janette marked this pull request as draft October 26, 2022 18:07
@janette janette changed the title Update admin_toolbar. Swap out dkan-tools with ddev-addon. Swap out dkan-tools with ddev-addon. Oct 26, 2022
composer.json Outdated
@@ -5,7 +5,7 @@
"minimum-stability": "dev",
"description": "DKAN Open Data Catalog",
"require": {
"drupal/admin_toolbar": "^2.3",
"drupal/admin_toolbar": "^3.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is now ^3 in the composer file, so maybe this change should be removed from the PR?

@janette janette force-pushed the upgrade-admin-toolbar branch from 46e780a to b80a407 Compare February 15, 2023 01:55
@janette janette marked this pull request as ready for review February 15, 2023 01:58
Copy link
Contributor

@jastraat jastraat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're moving to DDEV officially from DKAN Tools, this looks good!

@dafeder dafeder merged commit 651262a into 2.x Feb 21, 2023
@dafeder dafeder deleted the upgrade-admin-toolbar branch February 21, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants