Switch to simple built-in FileFetcher on import #3881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8a91f62.
janette
reviewed
Dec 14, 2022
janette
approved these changes
Dec 14, 2022
janette
pushed a commit
that referenced
this pull request
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The external FileFetcher library makes file downloads slower, and has led to failures/corruptions of data. Replacing it with a single FileFetcher job that copies a file all at once with Guzzle/cURL will lead to faster, more stable imports of large files. Our experience has been that downloading the file in chunks leads to more problems than it solves, at least as it works now.
The new FileFetcherJob class is all reused code from the FileFetcher library - specifically, the "LastResort" processor. Under this new paradigm the idea of a "processor" is no longer relevant. It's possible that in the future we would want to re-introduce the concept if our one-size solution does not actually fit all.
Local testing showed that a large remote CSV file that took 65 minutes to import completed in 20 minutes after making this change.
QA Steps