Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks to json_form_widget #3891

Merged
merged 4 commits into from
Dec 28, 2022
Merged

Add checks to json_form_widget #3891

merged 4 commits into from
Dec 28, 2022

Conversation

janette
Copy link
Member

@janette janette commented Dec 21, 2022

Fixes errors on the dataset form:
Warning: Undefined array key "#other_option" in Drupal\select_or_other\Element\ElementBase::addSelectField()

Warning: foreach() argument must be of type array|object, null given

Warning: Undefined array key "references" in Drupal\json_form_widget\ValueHandler->handleArrayValues()

Copy link
Contributor

@kaise-lafrai kaise-lafrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All manual tests and PHPUnit tests pass.

kaise-lafrai
kaise-lafrai approved these changes Dec 28, 2022
Copy link
Contributor

@kaise-lafrai kaise-lafrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@kaise-lafrai kaise-lafrai merged commit 15a2ed0 into 2.x Dec 28, 2022
@janette janette deleted the WCMS-12738 branch January 30, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants