Check if referenced node is already published before publishing again #3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janette
force-pushed
the
check-node-not-published
branch
from
c13a563 to
c7801e6
Compare
janette
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time a dataset or data dictionary is saved, all its references (themes, tags, etc) are checked. If they do not exist, they are created. If they do exist, they are set to published and resaved. This creates a new revision of every associated data node every time the dataset is saved.
This logic executed even if the theme/tag/etc was already published. This PR merely reduces the amount of additional node saves by only publishing/saving if the referenced node is unpublished.