Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 10 compatibility fixes #3931

Merged
merged 17 commits into from
Apr 12, 2023
Merged

Drupal 10 compatibility fixes #3931

merged 17 commits into from
Apr 12, 2023

Conversation

jastraat
Copy link
Contributor

@jastraat jastraat commented Mar 31, 2023

Based on our discussions in Slack and the fact that there were previous update hooks to uninstall the empty modules, this also removes the empty metastore_form and harvest_dashboard deprecated modules.

  • Test coverage exists
  • Documentation exists

@jastraat jastraat requested review from janette and dafeder March 31, 2023 16:32
@jastraat jastraat requested a review from paul-m April 3, 2023 13:23
paul-m
paul-m previously approved these changes Apr 3, 2023
Copy link
Contributor

@paul-m paul-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paul-m paul-m dismissed their stale review April 3, 2023 17:53

Take-backsies on my review. We can uncomment the D10 parts of the circle ci script.

@jastraat jastraat force-pushed the d10-deprecations branch 2 times, most recently from 4b94b76 to 225fdd2 Compare April 5, 2023 18:35
@jastraat jastraat force-pushed the d10-deprecations branch 3 times, most recently from fa88d34 to e8987ea Compare April 11, 2023 03:26
Copy link
Member

@dafeder dafeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dafeder dafeder merged commit 7600243 into 2.x Apr 12, 2023
@dafeder dafeder deleted the d10-deprecations branch April 12, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants