-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drupal 10 compatibility fixes #3931
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jastraat
force-pushed
the
d10-deprecations
branch
from
April 3, 2023 13:14
d06e1c7
to
0b4530e
Compare
janette
approved these changes
Apr 3, 2023
paul-m
previously approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
paul-m
dismissed
their stale review
April 3, 2023 17:53
Take-backsies on my review. We can uncomment the D10 parts of the circle ci script.
jastraat
force-pushed
the
d10-deprecations
branch
2 times, most recently
from
April 5, 2023 18:35
4b94b76
to
225fdd2
Compare
2 tasks
jastraat
force-pushed
the
d10-deprecations
branch
3 times, most recently
from
April 11, 2023 03:26
fa88d34
to
e8987ea
Compare
jastraat
force-pushed
the
d10-deprecations
branch
from
April 11, 2023 18:20
fd5cb93
to
8c47dbb
Compare
dafeder
reviewed
Apr 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on our discussions in Slack and the fact that there were previous update hooks to uninstall the empty modules, this also removes the empty metastore_form and harvest_dashboard deprecated modules.