Move admin_toolbar to recommended project #3937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The admin_toolbar module is not required for DKAN's functionality although almost all sites will have it installed for convenience.
We've moved the admin_toolbar dependency to the DKAN recommended project branches (all merged):
To allow the dependency to be moved, the Cypress tests that require admin toolbar are temporarily being skipped (#3935) Once this is committed, we should re-enable those.
As part of the notes for the next release, we should let users of DKAN know to add admin_toolbar and config_update to their project composer files.
WCMS-14268 needs to be completed before open data sites can take advantage of the release containing this change.