Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Cypress tests to match latest version of admin_toolbar #3964

Merged
merged 1 commit into from
May 11, 2023

Conversation

jastraat
Copy link
Contributor

@jastraat jastraat commented May 11, 2023

We were seeing errors with the most recent builds having failing Cypress tests.

admin_toolbar put out a new 3.4 release that reverted a number of earlier commits over the past 2 months including removing the expand/collapse buttons. https://git.drupalcode.org/project/admin_toolbar/-/commit/ed4b6816274525cb1866402812ce0b261b7421b3 (reverted in the 3.4 release)

We had updated the Cypress tests to match the version of admin_toolbar with those buttons in #3951 but since the changes in admin_toolbar were reverted, we need to revert our Cypress test changes.

  • Test coverage exists

@jastraat jastraat requested a review from dafeder May 11, 2023 19:09
@dafeder dafeder merged commit 7dc9d72 into 2.x May 11, 2023
@janette janette deleted the fix-admin-toolbar-cypress branch May 19, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants