Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide number widget in form #4215

Merged
merged 9 commits into from
Jul 3, 2024
Merged

Provide number widget in form #4215

merged 9 commits into from
Jul 3, 2024

Conversation

dafeder
Copy link
Member

@dafeder dafeder commented Jul 3, 2024

Re-roll/add test coverage for #4069 by @stefan-korn

QA steps

Add a field to the dataset.json schema file:

    "number": {
      "title": "Number",
      "description": "A unique number for the dataset or API as maintained within an Agency catalog or database.",
      "type": "string",
      "minLength": 1
    }

now add settings to dataset.ui.json:

  "number": {
    "ui:options": {
      "widget": "number",
      "step": 10
    }
  }

Go to create dataset form, confirm there is a number widget that increments by 10 on every click.

@dafeder dafeder mentioned this pull request Jul 3, 2024
3 tasks
@dafeder dafeder marked this pull request as ready for review July 3, 2024 13:42
Copy link
Contributor

@kaise-lafrai kaise-lafrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and QA steps passed. One small request is to update the code comment for the numberField in the WidgetRouterTest.

@kaise-lafrai kaise-lafrai merged commit 6d4819d into 2.x Jul 3, 2024
9 checks passed
@dafeder dafeder mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants