Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drush deregister improvements #4272

Merged
merged 12 commits into from
Sep 16, 2024
Merged

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented Sep 3, 2024

Fixes [issue#]

Describe your changes

Modifies drush dkan:harvest:deregister:

  • Adds a confirmation step ('Are you sure?'). Can be bypassed with -y, --yes, or --no-interaction.
  • Adds a flag to the command line, --revert. This will revert all datasets in the harvest before deregistering, and is the equivalent of drush dkan:harvest:revert ID && drush dkan:harvest:deregister ID

QA Steps

  • Add manual QA steps in checklist format for a reviewer to perform. Be as specific as possible, provide examples if appropriate.

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added tests to cover my code
  • I have updated or added documentation

@paul-m paul-m marked this pull request as ready for review September 11, 2024 18:50
@@ -123,6 +123,11 @@ dkan:harvest:deregister
**Arguments**
Copy link
Member

@janette janette Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's define this a little more on line 121.

Deregister a harvest. This action removes the harvest plan from the system, but will leave the datasets in place. This is good if you are using harvest to migrate content and you do not plan on using the harvest feature to update the datasets.
If you want to remove the harvest plan AND the datasets associated with it, use the --revert option.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update the dkan:harvest:revert description

Revert a harvest, i.e. remove harvested entities and unpublish orhpaned keywords, themes, and distributions. The harvest plan will remain and can be run again to generate the datasets after any issues have been resolved.

@janette janette merged commit 485fccd into 2.x Sep 16, 2024
11 checks passed
@janette janette deleted the 21517-drush-deregister-improvements branch September 16, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants