Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'Other' option from File Format select list for Dataset Distributions. #4318

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

beeyayjay
Copy link
Contributor

@beeyayjay beeyayjay commented Oct 16, 2024

(15468)
Distribution File Format select list should not allow publishers to upload ANY file format, the allowed types should be set in the schema by the site maintainer.

Describe your changes

Changed Distribution Format list type from 'select_other' to select.

QA Steps

  • Add manual QA steps in checklist format for a reviewer to perform. Be as specific as possible, provide examples if appropriate.

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added tests to cover my code
  • I have updated or added documentation

@janette
Copy link
Member

janette commented Nov 4, 2024

Tests need to be updated.

@beeyayjay beeyayjay force-pushed the 15468-distrib-format-select branch from db44b38 to 1c69293 Compare November 12, 2024 16:56
@beeyayjay
Copy link
Contributor Author

Tests updated. All passing now.

@beeyayjay beeyayjay force-pushed the 15468-distrib-format-select branch from 1c69293 to 5209ad9 Compare November 27, 2024 20:36
@janette janette merged commit 621803a into 2.x Dec 4, 2024
11 checks passed
@janette janette deleted the 15468-distrib-format-select branch December 4, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants