Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @covers annotation #4388

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Fix @covers annotation #4388

merged 1 commit into from
Jan 22, 2025

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented Jan 21, 2025

Fixes [issue#]

Describe your changes

This cleans up our CI workflow, where we have seen difficulty with the 'uploading test results' phase.

Screenshot 2025-01-22 at 12 45 44 PM

This was because we had some code coverage annotation in need of fixing, which was adding 'warning' elements to the PHPUnit JUnit report, which in turn caused CircleCI to behave strangely.

TODO: Figure out why CircleCI can't process warning results.

QA Steps

  • Visit CircleCI from the CI run here and verify that it does not exhibit errors.

@paul-m paul-m marked this pull request as ready for review January 22, 2025 20:48
@paul-m paul-m changed the title Fixes @covers annotation Fix @covers annotation Jan 22, 2025
@rovcase rovcase self-requested a review January 22, 2025 20:59
Copy link
Contributor

@rovcase rovcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All eight Circle CI jobs not reporting any errors (in particular on the Uploading test results section), LGTM. Thanks!

@rovcase rovcase merged commit 4d489b6 into 2.x Jan 22, 2025
11 checks passed
@rovcase rovcase deleted the fix-covers-annotation branch January 22, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants