fix: Correct labeler.yml config #127
Conversation
WalkthroughReplaces explicit per-label path lists and exclusion patterns in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/labeler.yml (1)
93-103: Eliminate redundant glob patterns inconfiglabel.Several patterns are redundant and can be consolidated:
- Line 100:
**/pyproject.tomlis redundant with line 94's**/*.toml- Line 101:
**/pytest.iniis redundant with line 98's**/*.ini- Lines 95–99 are already very broad (all
.yml,.yaml,.json,.ini,.cfg) and may be overly permissiveConsider whether this breadth is intentional or if config patterns should be narrower (e.g., root-level and
.github/only).Apply this diff to consolidate:
config: - changed-files: - any-glob-to-any-file: '**/*.toml' - any-glob-to-any-file: '**/*.yml' - any-glob-to-any-file: '**/*.yaml' - any-glob-to-any-file: '**/*.json' - any-glob-to-any-file: '**/*.ini' - any-glob-to-any-file: '**/*.cfg' - - any-glob-to-any-file: '**/pyproject.toml' - - any-glob-to-any-file: '**/pytest.ini' - any-glob-to-any-file: '**/conftest.py'
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/labeler.yml(1 hunks)
🔇 Additional comments (3)
.github/labeler.yml (3)
86-90: Verify glob patterns fordocslabel — potential over-reach to non-documentation markdown.The pattern
**/*.mdon line 89 matches markdown files throughout the entire repository, not just documentation. This will label pull requests modifyingREADME.md,CHANGELOG.md, or any*.mdin subdirectories (includingplugins/*/README.md) asdocs, which may not align with intent.Consider scoping to:
docs/**and root-level documentation files (README.md,CHANGELOG.md, etc.) if the goal is narrower.
145-155: Verify glob patterns forassetslabel — media file patterns are repository-wide.The patterns
**/*.png,**/*.jpg,**/*.jpeg,**/*.gif,**/*.mp4,**/*.wav,**/*.mp3on lines 148–154 match media files anywhere in the repository. If the intent is to label only files in theassets/directory, these should be scoped (e.g.,assets/**/*.png).As written, a PNG file added to
plugins/some_plugin/preview.pngwould incorrectly receive theassetslabel.
164-169: Verify scope ofproject-infolabel patterns.The patterns on lines 165–168 (
**/README.md,**/CHANGELOG.md,**/CONTRIBUTING.md,**/SECURITY.md) will match these files in any subdirectory. If the label should apply only to root-level project metadata, these patterns are too broad.For example,
plugins/some_plugin/README.mdwould incorrectly receive theproject-infolabel instead of a plugin-specific label.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/labeler.yml (2)
87-89: Note: Broad glob patterns may over-label.The
**/*.mdpattern (line 89) will match markdown files anywhere in the repository—including changelogs, contribution guides, and READMEs in non-docs directories. If this broad behavior is intentional (to label all documentation-related changes), document it. Otherwise, consider constraining todocs/**/*.mdto match only files within the docs directory.
145-154: Note: Asset glob patterns may match files outside assets/ directory.The asset media globs (
**/*.png,**/*.jpg,**/*.mp4, etc.) will match media files anywhere in the repository—including images in documentation or examples. Verify this broad matching is intentional. If strict scoping to the assets/ directory is preferred, adjust toassets/**/*.{png,jpg,jpeg,gif,mp4,wav,mp3}.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/labeler.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: unit / Ruff & mypy
- GitHub Check: unit / Test "not integration"
🔇 Additional comments (2)
.github/labeler.yml (2)
1-169: LGTM: Config now complies with actions/labeler specification.The restructured format correctly addresses the reported CI error by wrapping each label's configuration as an array of objects, each containing a
changed-filescondition with one or moreany-glob-to-any-fileglob patterns. This matches the actions/labeler usage specification referenced in the PR.
79-83: Note: Test patterns provide comprehensive but overlapping coverage.The four patterns (line 79–83) create deliberate overlap:
tests/**catches the tests directory,**/tests/**catches nested test directories, and**/test_*.py+**/*_test.pycatch test files by naming convention regardless of location. If the labeler deduplicates matching files (likely), this is fine. Otherwise, a file matching multiple patterns could be labeled multiple times.
2 participants
Fixes the labeler.yml config. See docs for reference: https://github.com/actions/labeler?tab=readme-ov-file#usage.
This should fix the CI issue
Summary by CodeRabbit