Skip to content

fix: remove duplicate track publishing code #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

fix: remove duplicate track publishing code #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions agents-core/vision_agents/core/agents/agents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,17 +241,6 @@ async def join(self, call: Call) -> "AgentSessionContextManager":
audio_track = self._audio_track if self.publish_audio else None
video_track = self._video_track if self.publish_video else None

if audio_track or video_track:
with self.tracer.start_as_current_span("edge.publish_tracks"):
await self.edge.publish_tracks(audio_track, video_track)
await self._listen_to_audio_and_video()

self.logger.info(f"🤖 Agent joined call: {call.id}")

# Set up audio and video tracks together to avoid SDP issues
audio_track = self._audio_track if self.publish_audio else None
video_track = self._video_track if self.publish_video else None

if audio_track or video_track:
with self.tracer.start_as_current_span("edge.publish_tracks"):
await self.edge.publish_tracks(audio_track, video_track)
Expand Down Expand Up @@ -631,6 +620,10 @@ async def _process_track(self, track_id: str, track_type: str, participant):
self.logger.info("No image processors, video processing handled by video processors only")
return

# Initialize error tracking counters
timeout_errors = 0
consecutive_errors = 0

while True:
try:
# Use the shared forwarder instead of competing for track.recv()
Expand Down Expand Up @@ -660,6 +653,7 @@ async def _process_track(self, track_id: str, track_type: str, participant):

except asyncio.TimeoutError:
# Exponential backoff for timeout errors
timeout_errors += 1
backoff_delay = min(2.0 ** min(timeout_errors, 5), 30.0)
self.logger.debug(
f"🎥VDP: Applying backoff delay: {backoff_delay:.1f}s"
Expand Down