Skip to content

fix: reject promise if peer connection observer is not found #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2024
Merged

fix: reject promise if peer connection observer is not found #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
034c031
fix: promise reject if peer connection observer is not found
santhoshvai Oct 10, 2024
ea2cdb2
118.1.2-alpha.1
santhoshvai Oct 10, 2024
bce3f20
fix final values
santhoshvai Oct 10, 2024
97f1968
118.1.2-alpha.2
santhoshvai Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/src/main/java/com/oney/WebRTCModule/WebRTCModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,7 @@ public void peerConnectionSetConfiguration(ReadableMap configuration, int id) {
public void peerConnectionCreateOffer(int id, ReadableMap options, Promise promise) {
ThreadUtils.runOnExecutor(() -> {
PeerConnectionObserver pco = mPeerConnectionObservers.get(id);
PeerConnection peerConnection = pco.getPeerConnection();
PeerConnection peerConnection = pco == null ? null : pco.getPeerConnection();

if (peerConnection == null) {
Log.d(TAG, "peerConnectionCreateOffer() peerConnection is null");
Expand Down Expand Up @@ -1128,7 +1128,7 @@ public void onSetFailure(String s) {
public void peerConnectionSetRemoteDescription(int id, ReadableMap desc, Promise promise) {
ThreadUtils.runOnExecutor(() -> {
PeerConnectionObserver pco = mPeerConnectionObservers.get(id);
PeerConnection peerConnection = pco.getPeerConnection();
PeerConnection peerConnection = pco == null ? null : pco.getPeerConnection();

if (peerConnection == null) {
Log.d(TAG, "peerConnectionSetRemoteDescription() peerConnection is null");
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@stream-io/react-native-webrtc",
"version": "118.1.1",
"version": "118.1.2-alpha.2",
"repository": {
"type": "git",
"url": "git+https://github.com/GetStream/react-native-webrtc.git"
Expand Down
Loading