Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i200] add MessageDateSeparatorTheme #5014

Merged
merged 4 commits into from
Oct 24, 2023
Merged

[i200] add MessageDateSeparatorTheme #5014

merged 4 commits into from
Oct 24, 2023

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Oct 20, 2023 •
edited
Loading

🎯 Goal

Closes https://github.com/GetStream/android-internal-board/issues/200

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the v5 branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat requested a review from a team as a code owner October 20, 2023 22:12
@kanat kanat changed the title Bugfix/date text color v5 [i200] add MessageDateSeparatorTheme Oct 20, 2023
@kanat kanat changed the base branch from main to v5 October 20, 2023 22:14
@kanat kanat added compose Jetpack Compose v5 enhancement New feature or request labels Oct 20, 2023
kanat added 4 commits October 24, 2023 08:11
@kanat
[i200] DateSeparator uses BG color for text
82b0064 
(cherry picked from commit 34e0499)

# Conflicts:
#	stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/list/MessageContainer.kt
@kanat
[i200] add MessageDateSeparatorTheme
315e801 
(cherry picked from commit 429b41e)

# Conflicts:
#	stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/list/MessageContainer.kt
#	stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/theme/ChatTheme.kt
@kanat
[i200] add CHANGELOG
a7ad4a1
@kanat
[i200] fix api dump
a429bdc
@kanat kanat force-pushed the bugfix/date_text_color_v5 branch from da8c0fc to a429bdc Compare October 24, 2023 15:15
@kanat kanat enabled auto-merge (squash) October 24, 2023 15:30
@kanat kanat merged commit 334b6c2 into v5 Oct 24, 2023
@kanat kanat deleted the bugfix/date_text_color_v5 branch October 24, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNovak DanielNovak DanielNovak approved these changes

Assignees
No one assigned
Labels
compose Jetpack Compose enhancement New feature or request v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanat @DanielNovak