Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i209] allow override channel options visibility #5044

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Nov 7, 2023

🎯 Goal

Closes: https://github.com/GetStream/android-internal-board/issues/209

🛠 Implementation details

Instead having the following condition in ChannelViewHolder

channel.ownCapabilities.contains(ChannelCapabilities.DELETE_CHANNEL)

It now was used as a default condition for isDeleteOptionVisible: ChannelOptionVisibilityPredicate

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat added enhancement New feature or request ui-components v5 labels Nov 7, 2023
@kanat kanat marked this pull request as ready for review November 7, 2023 21:31
@kanat kanat requested a review from a team as a code owner November 7, 2023 21:31
@kanat kanat changed the title [i209] allow override channel options visibility#209 [i209] allow override channel options visibility Nov 7, 2023
@JcMinarro JcMinarro enabled auto-merge (rebase) November 8, 2023 10:33
@JcMinarro JcMinarro force-pushed the enhancement/channel-delete-option branch from 03dedb5 to cb09cac Compare November 8, 2023 10:33
@JcMinarro JcMinarro merged commit b1c24f8 into v5 Nov 8, 2023
@JcMinarro JcMinarro deleted the enhancement/channel-delete-option branch November 8, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants