Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i214] Preserve default behaviour when binding composer VM #5059

Merged
merged 3 commits into from
Nov 13, 2023
Merged

[i214] Preserve default behaviour when binding composer VM #5059

merged 3 commits into from
Nov 13, 2023

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Nov 10, 2023

🎯 Goal

Closes: https://github.com/GetStream/android-internal-board/issues/214

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat marked this pull request as ready for review November 10, 2023 22:54
@kanat kanat requested a review from a team as a code owner November 10, 2023 22:54
@kanat kanat added ui-components v5 enhancement New feature or request labels Nov 10, 2023
@kanat kanat changed the title [i214] Preserve default behaviour when passing bindView listeners [i214] Preserve default behaviour when binding composer Nov 10, 2023
@kanat kanat changed the title [i214] Preserve default behaviour when binding composer [i214] Preserve default behaviour when binding composer VM Nov 10, 2023
@JcMinarro JcMinarro enabled auto-merge (rebase) November 13, 2023 12:45
@JcMinarro JcMinarro merged commit 805cd27 into v5 Nov 13, 2023
5 checks passed
@JcMinarro JcMinarro deleted the enhancement/composer-bind-view branch November 13, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcMinarro JcMinarro JcMinarro approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request ui-components v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanat @JcMinarro