Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Messages sent ofline weren't initializing the date when the message was created and if we didn't update the message from the one that is returned from backend, we could arrive to condition where it is not updated never causing a crash when the date of all messages is used to sort a conversation.
Apart of that, if we jump to a message in the past, it could cause a gap on the conversation due the pagination was not implemented properly.
I have created a method to be sure any gap on the conversation list is filled when the State module is used.
Fix: #5034
🧪 Testing
To test it, you will need to jump to a message in the pass within a conversation.
I have create a channel where there are an indexed list of messages to verify the list of messages is loaded properly.
Open the UI-Component sample app, login with "Jc Miñarro" user and click on the conversation with "Daren".
You will need to apply the following patch to ensure you are jumping to the message
50
Patch code to automatically jump to message `50` when go into conversation with "Daren"
🎉 GIF