Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Regex not escaped in getOccurrenceRanges #5108

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fix Regex not escaped in getOccurrenceRanges #5108

merged 1 commit into from
Dec 7, 2023

Conversation

DanielNovak
Copy link
Contributor

@DanielNovak DanielNovak commented Dec 7, 2023 •
edited
Loading

This function can lead to a crash if the items contain invalid Regex strings (e.g. "Ryan :)")

@DanielNovak DanielNovak added bug Something isn't working v5 labels Dec 7, 2023
@DanielNovak DanielNovak requested a review from a team as a code owner December 7, 2023 18:28
kanat
kanat approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@kanat kanat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielNovak DanielNovak enabled auto-merge (squash) December 7, 2023 18:31
@DanielNovak DanielNovak merged commit a9a4411 into v5 Dec 7, 2023
5 checks passed
@DanielNovak DanielNovak deleted the fix_regex_escape branch December 7, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanat kanat kanat approved these changes

Assignees
No one assigned
Labels
bug Something isn't working v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielNovak @kanat