Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i225] fix message list scrolling on a new message #5112

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Dec 8, 2023

🎯 Goal

Closes:

🛠 Implementation details

It looks like Compose is not dealing well with a state which contains the object properties.
From the logs perspective I saw the MessageListController emits all the changes, however, Compose was taking just the last emission as recomposition trigger.

On top of that, using data class with ts will help us to avoid cases where we keep using NewMessageState.Other object for diff messages. Currently all of such changes are ignored.

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat added bug Something isn't working compose Jetpack Compose v6 labels Dec 8, 2023
@kanat kanat marked this pull request as ready for review December 8, 2023 23:19
@kanat kanat requested a review from a team as a code owner December 8, 2023 23:19
@JcMinarro JcMinarro enabled auto-merge (rebase) December 11, 2023 10:28
@JcMinarro JcMinarro merged commit 8c369de into develop Dec 11, 2023
7 checks passed
@JcMinarro JcMinarro deleted the bugfix/scrolling-issue-v6 branch December 11, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compose Jetpack Compose v6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants