[i225] fix message list scrolling on a new message #5112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Closes:
🛠 Implementation details
It looks like Compose is not dealing well with a
state
which contains theobject
properties.From the logs perspective I saw the
MessageListController
emits all the changes, however,Compose
was taking just the last emission as recomposition trigger.On top of that, using
data class
withts
will help us to avoid cases where we keep usingNewMessageState.Other
object for diff messages. Currently all of such changes are ignored.☑️Contributor Checklist
General
develop
branchCode & documentation
☑️Reviewer Checklist
🎉 GIF
Please provide a suitable gif that describes your work on this pull request