Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proguard / R8 integration for the default rule configuration #5272

Merged
merged 3 commits into from
May 31, 2024
Merged

Add proguard / R8 integration for the default rule configuration #5272

merged 3 commits into from
May 31, 2024

Conversation

skydoves
Copy link
Member

Add proguard / R8 integration for the default rule configuration.

references:

google/gson#2397

@skydoves skydoves self-assigned this May 31, 2024
@skydoves skydoves requested a review from a team as a code owner May 31, 2024 04:06
JcMinarro
JcMinarro requested changes May 31, 2024
View reviewed changes
Copy link
Member

@JcMinarro JcMinarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we need to use different file names per artifact to be sure there aren't any conflicts when our customer apps are compiled

@JcMinarro JcMinarro merged commit a336364 into develop May 31, 2024
7 checks passed
@JcMinarro JcMinarro deleted the add/proguard-rules branch May 31, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcMinarro JcMinarro JcMinarro approved these changes

Assignees

@skydoves skydoves

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skydoves @JcMinarro