Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PBE-4089] Store Poll in our local db #5283

Merged
merged 14 commits into from
Aug 12, 2024
Merged

[PBE-4089] Store Poll in our local db #5283

merged 14 commits into from
Aug 12, 2024

Conversation

JcMinarro
Copy link
Member

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 13, 2024 •
edited
Loading

DB Entities have been updated. Do we need to upgrade DB Version?
Modified Entities :

stream-chat-android-offline/src/main/java/io/getstream/chat/android/offline/repository/domain/message/internal/MessageEntity.kt
stream-chat-android-offline/src/main/java/io/getstream/chat/android/offline/repository/domain/message/internal/Poll.kt
stream-chat-android-offline/src/main/java/io/getstream/chat/android/offline/repository/domain/message/internal/ReplyMessageEntity.kt

@JcMinarro JcMinarro force-pushed the feature/offline-polls branch from 5116c8d to 448559e Compare June 13, 2024 22:16
@JcMinarro
Copy link
Member Author

DB Entities have been updated. Do we need to upgrade DB Version? Modified Entities :

stream-chat-android-offline/src/main/java/io/getstream/chat/android/offline/repository/domain/message/internal/MessageEntity.kt
stream-chat-android-offline/src/main/java/io/getstream/chat/android/offline/repository/domain/message/internal/ReplyMessageEntity.kt

DB Version is already upgrade 🙃

@JcMinarro JcMinarro force-pushed the feature/offline-polls branch from 448559e to 8844ffa Compare June 14, 2024 11:47
@JcMinarro JcMinarro mentioned this pull request Jun 14, 2024
Merged
@JcMinarro JcMinarro requested review from kanat and skydoves June 14, 2024 13:08
@JcMinarro JcMinarro force-pushed the feature/offline-polls branch from 8844ffa to f02966e Compare July 24, 2024 11:08
@JcMinarro JcMinarro mentioned this pull request Jul 25, 2024
Merged
@JcMinarro JcMinarro force-pushed the feature/offline-polls branch from f02966e to 71b9598 Compare August 8, 2024 11:30
@JcMinarro JcMinarro marked this pull request as ready for review August 8, 2024 11:33
@JcMinarro JcMinarro requested a review from a team as a code owner August 8, 2024 11:33
kanat
kanat approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@kanat kanat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

skydoves
skydoves approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@JcMinarro JcMinarro enabled auto-merge (rebase) August 12, 2024 10:11
@JcMinarro JcMinarro force-pushed the feature/offline-polls branch from 71b9598 to 7342314 Compare August 12, 2024 10:13
@JcMinarro JcMinarro merged commit f24363a into develop Aug 12, 2024
7 checks passed
@JcMinarro JcMinarro deleted the feature/offline-polls branch August 12, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skydoves skydoves skydoves approved these changes

@kanat kanat kanat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JcMinarro @kanat @skydoves