Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose Poll creation UI attachment components (1) #5305

Merged
merged 40 commits into from
Jul 26, 2024

Conversation

skydoves
Copy link
Member

@skydoves skydoves commented Jun 25, 2024

🎯 Goal

[WIP] Compose Poll creation UI components

🛠 Implementation details

  • Add the poll icon on the attachment bottom sheet
  • Navigate to the poll creation screen with a transition animation
  • Navigation back to the chat screen with a transition animation
  • The entire poll creation screen (questions with input fields, options with input fields, and they should be
  • Nested vertical scrollable (dynamic height of a list)
  • movable/reordering by drag and drop, multiple switches to limit poll options)
  • Implement an AlertDialog to ask whether a user wants to discard the poll creation screen.

🎨 UI Changes

Screenshot 2024-06-25 at 6 56 25 PM

Screenshot 2024-06-26 at 3 36 08 PM

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@skydoves skydoves self-assigned this Jun 25, 2024
@skydoves skydoves marked this pull request as ready for review June 27, 2024 07:17
@skydoves skydoves requested a review from a team as a code owner June 27, 2024 07:17
@skydoves skydoves changed the title [WIP] Compose Poll creation UI components Compose Poll creation UI components Jun 27, 2024
@skydoves skydoves added compose Jetpack Compose v6 labels Jun 28, 2024
@skydoves skydoves changed the title Compose Poll creation UI components Compose Poll creation UI components (Attachment) Jul 1, 2024
@skydoves skydoves changed the title Compose Poll creation UI components (Attachment) Compose Poll creation UI attachment components (1) Jul 3, 2024
@kanat kanat enabled auto-merge (squash) July 8, 2024 19:31
@kanat kanat disabled auto-merge July 8, 2024 19:32
Copy link
Collaborator

@kanat kanat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kanat
Copy link
Collaborator

kanat commented Jul 8, 2024

@skydoves I can see in the PR summary

[WIP] Compose Poll creation UI components

Is this still in WIP?

@kanat
Copy link
Collaborator

kanat commented Jul 8, 2024

@skydoves which PR should be merged first, this one or #5308? 🙂

@skydoves
Copy link
Member Author

skydoves commented Jul 9, 2024

@kanat This feature is quite large, so I split it into three different PRs. We should merge them in reverse order: (3 #5311) -> (2 #5308) -> (1 #5305) -> develop.

@JcMinarro JcMinarro merged commit 027a606 into develop Jul 26, 2024
7 checks passed
@JcMinarro JcMinarro deleted the feature/compose-poll branch July 26, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compose Jetpack Compose v6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants