-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compose Poll creation UI attachment components (1) #5305
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entsPickerTabFactory
skydoves
changed the title
[WIP] Compose Poll creation UI components
Compose Poll creation UI components
Jun 27, 2024
…tream-chat-android into feature/compose-poll
skydoves
changed the title
Compose Poll creation UI components
Compose Poll creation UI components (Attachment)
Jul 1, 2024
aleksandar-apostolov
approved these changes
Jul 1, 2024
skydoves
changed the title
Compose Poll creation UI components (Attachment)
Compose Poll creation UI attachment components (1)
Jul 3, 2024
kanat
reviewed
Jul 8, 2024
...roid_versioned_docs/version-5.x.x/04-compose/05-message-components/05-attachments-picker.mdx
Outdated
Show resolved
Hide resolved
kanat
reviewed
Jul 8, 2024
.../version-6.x.x-before-refactoring/05-compose/05-message-components/05-attachments-picker.mdx
Outdated
Show resolved
Hide resolved
kanat
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@skydoves I can see in the PR summary
Is this still in WIP? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
[WIP] Compose Poll creation UI components
🛠 Implementation details
🎨 UI Changes
☑️Contributor Checklist
General
develop
branchCode & documentation
☑️Reviewer Checklist
🎉 GIF
Please provide a suitable gif that describes your work on this pull request