Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBE-5891] Remove NotInFilterObject #5394

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

JcMinarro
Copy link
Member

🎯 Goal

Depend on #5393
This PR removes the NotInFilterObject class that is not supported backend-side anymore.
We needs to wait one release before it can be merged

🎉 GIF

@JcMinarro JcMinarro changed the title [PBE-5891] Remove NotInFilterObject [NOT MERGE YET] [PBE-5891] Remove NotInFilterObject Sep 3, 2024
@aleksandar-apostolov
Copy link
Collaborator

Why do we need to wait for the backend to remove this? I think it will stay there for backward compatibility. Is it an issue if we remove it client side? I think this is the desired behavior.

@JcMinarro
Copy link
Member Author

@aleksandar-apostolov We are not waiting to the backend implementation but our deprecation process.
It is a breaking change that we should provide some adaptative time for it

@JcMinarro JcMinarro force-pushed the feature/remove-not-in-filter branch from 133e05a to 04a40f8 Compare September 30, 2024 14:30
@JcMinarro JcMinarro marked this pull request as ready for review September 30, 2024 14:34
@JcMinarro JcMinarro requested a review from a team as a code owner September 30, 2024 14:34
@JcMinarro JcMinarro changed the title [NOT MERGE YET] [PBE-5891] Remove NotInFilterObject [PBE-5891] Remove NotInFilterObject Sep 30, 2024
@aleksandar-apostolov aleksandar-apostolov enabled auto-merge (squash) October 1, 2024 09:12
@aleksandar-apostolov aleksandar-apostolov merged commit 7bfe302 into develop Oct 1, 2024
7 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the feature/remove-not-in-filter branch October 1, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants