[PBE-5896] Fix/async voice compose render #5395
Merged
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JcMinarro
force-pushed
the
fix/async-voice-compose-render
branch
from
44c9405 to
e6623b4
Compare
|
Hey @JcMinarro, Would you mind waiting when I finish the Voice Recording Impl for Compose? :) |
…mpose-render # Conflicts: # stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/attachments/StreamAttachmentFactories.kt
kanat
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Async-Voice attachments weren't rendered properly on Compose SDK on some situations.
Some internal properties caused it, which we use in our attachments to track the upload process.
Apart of that, the attachments factories has been reordered to ensure Async-Voice attachments use the proper factory
🎉 GIF