[PBE-6017] message list does not scroll on new msg #5427
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Closes:
Related PR:
ℹ️ Details
It seems like this is a side effect of the fix for XML (#5280).
NewMessageState
changes too fast for Compose to reflect all state changes, that leads to position where Compose thinks that nothing has changed.I've revisited scrolling logic in both XML and Compose:
NewMessageState
should always reflect latest new message, we only change it when a new message is being receivedMessageListScrollHelper
MessageListControllerTests
to make sure we won't break statement from N1☑️Contributor Checklist
General
develop
branchCode & documentation
☑️Reviewer Checklist
🎉 GIF
Please provide a suitable gif that describes your work on this pull request