Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AND-5] Expand message theming #5466

Merged
merged 14 commits into from
Nov 11, 2024
Merged

[AND-5] Expand message theming #5466

merged 14 commits into from
Nov 11, 2024

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Nov 7, 2024

🎯 Goal

Closes:

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat requested a review from a team as a code owner November 7, 2024 00:59
@kanat kanat changed the base branch from main to develop November 7, 2024 00:59
kanat
kanat commented Nov 7, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@kanat kanat requested a review from VelikovPetar November 7, 2024 19:06
@kanat kanat requested a review from JcMinarro November 7, 2024 23:42
@JcMinarro JcMinarro enabled auto-merge (rebase) November 11, 2024 15:44
@JcMinarro JcMinarro merged commit 8363511 into develop Nov 11, 2024
7 checks passed
@JcMinarro JcMinarro deleted the message-theming branch November 11, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcMinarro JcMinarro JcMinarro approved these changes

@VelikovPetar VelikovPetar Awaiting requested review from VelikovPetar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kanat @JcMinarro @VelikovPetar