Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channel list blinking UI when resuming from a paused state #5521

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

andremion
Copy link
Contributor

@andremion andremion commented Dec 16, 2024

🎯 Goal

Fix the blinking UI when resuming from a paused state, for example, after switching back from the recent apps.

🛠 Implementation details

The previous implementation switched the channel list by the loading UI even when there were results in the list, causing the blink when the screen is resumed from a paused state.

The proposed implementation prevents that blinking by not rendering the loading UI if there is any result.

🎨 UI Changes

Before After
before-ezgif com-video-to-gif-converter after-ezgif com-video-to-gif-converter

🧪 Testing

It can be reproduced by switching apps from the recent apps or resuming from a minimized state.

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

GIF

@andremion andremion added the compose Jetpack Compose label Dec 16, 2024
@andremion andremion marked this pull request as ready for review December 16, 2024 13:07
@andremion andremion requested a review from a team as a code owner December 16, 2024 13:07
@andremion andremion changed the title Fix channel list blinking UI when resuming from the recent apps. Fix channel list blinking UI when resuming from a paused state Dec 17, 2024
@andremion andremion requested a review from JcMinarro December 17, 2024 09:05
@JcMinarro JcMinarro enabled auto-merge (squash) December 17, 2024 12:53
@JcMinarro JcMinarro force-pushed the fix-channel-list-blinking branch from 5b63b64 to 4d80c5d Compare December 17, 2024 12:53
@JcMinarro JcMinarro merged commit 4f53f7b into develop Dec 17, 2024
9 checks passed
@JcMinarro JcMinarro deleted the fix-channel-list-blinking branch December 17, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compose Jetpack Compose
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants