[AND-203] Fix system messages not hidden if showSystemMessages=false. #5546
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
The
MessageListController
flagshowSystemMessages
was not respected, due to theDeletedMessageVisibility
taking precedence. We now properly take this flag into consideration, if the message is not deleted.🛠 Implementation details
Change the
MessageListController.filterMessagesToShow
logic to consider theDeletedMessageVisibility
when the message is deleted, and considershowSystemMessages
if the message is a system one.🎨 UI Changes
Scenario where showSystemMessages = false
before.mp4
after.mp4
🧪 Testing
Patch