Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): namespace not specified for video_thumbnail package. #2049

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix(ui): namespace not specified for video_thumbnail package. #2049

merged 2 commits into from
Nov 18, 2024

Conversation

xsahil03x
Copy link
Member

Fixes: #2030

@xsahil03x xsahil03x changed the title fix: fix namespace not specified for video_thumbnail package. fix(ui): namespace not specified for video_thumbnail package. Nov 18, 2024
@xsahil03x xsahil03x requested a review from deven98 November 18, 2024 11:25
@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 60.29%. Comparing base (099667f) to head (7bcd0fe).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ream_chat_flutter/lib/src/video/video_service.dart 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2049   +/-   ##
=======================================
  Coverage   60.28%   60.29%           
=======================================
  Files         318      318           
  Lines       18583    18580    -3     
=======================================
  Hits        11202    11202           
+ Misses       7381     7378    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

deven98
deven98 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@deven98 deven98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xsahil03x xsahil03x merged commit 4b062b2 into master Nov 18, 2024
16 of 18 checks passed
@xsahil03x xsahil03x deleted the feat/get-video-thumbnail branch November 18, 2024 12:33
@pcj
Copy link

pcj commented Dec 3, 2024

Would be nice to have new release with this one... 8.2.1?

@xsahil03x xsahil03x mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deven98 deven98 deven98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

video_thumbnail: Namespace not specified. Specify a namespace in the module's build file.
3 participants
@xsahil03x @pcj @deven98