-
Notifications
You must be signed in to change notification settings - Fork 370
refactor(ui)!: re-wrote message actions and modals #2156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f56bed
to
a42c738
Compare
0cde3d3
to
4a8c9ef
Compare
47293cc
to
625524b
Compare
7ce3ee7
to
38156e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request refactors the message actions and modal system to consolidate duplicated UI components and improve type safety. Key changes include:
- Removal of individual action button widgets in favor of a generic, reusable builder (StreamMessageActionsBuilder) and modal (StreamMessageModal).
- Updates to the retry logic in channel operations and localization tweaks for consistency.
- Various cleanups and removals of legacy context menu and action files to streamline the codebase.
Reviewed Changes
Copilot reviewed 101 out of 101 changed files in this pull request.
Show a summary per file
File | Description |
---|---|
packages/stream_chat_flutter/lib/src/message_actions_modal/* | Removed legacy message action button widgets in favor of a centralized approach. |
packages/stream_chat_flutter/lib/src/message_action/message_actions_builder.dart | Introduced a new builder class to generate message actions based on state and channel capabilities. |
packages/stream_chat_flutter/lib/src/message_action/* | Added new generic message action types and updated related widgets for improved type safety. |
packages/stream_chat_flutter/lib/src/fullscreen_media/full_screen_media_desktop.dart | Updated DownloadMenuItem integration and adjusted menu builder for desktop media. |
packages/stream_chat_flutter/lib/src/localization/translations.dart | Revised error messages to remove line breaks and standardize wording. |
packages/stream_chat_flutter/lib/src/channel/channel.dart | Updated retryMessage logic with enhanced assertions and clearer retry paths. |
packages/stream_chat_flutter/CHANGELOG.md, dart_test.yaml | Updated changelog and test configuration to reflect the refactor. |
renefloor
reviewed
May 14, 2025
packages/stream_chat_flutter/lib/src/fullscreen_media/full_screen_media_desktop.dart
Outdated
Show resolved
Hide resolved
packages/stream_chat_flutter/lib/src/message_action/message_action_type.dart
Show resolved
Hide resolved
packages/stream_chat_flutter/lib/src/message_modal/message_action_confirmation_modal.dart
Show resolved
Hide resolved
renefloor
reviewed
May 15, 2025
packages/stream_chat_flutter/lib/src/message_modal/message_modal.dart
Outdated
Show resolved
Hide resolved
packages/stream_chat_flutter/lib/src/message_modal/message_modal.dart
Outdated
Show resolved
Hide resolved
packages/stream_chat_flutter/lib/src/message_modal/message_reactions_modal.dart
Outdated
Show resolved
Hide resolved
packages/stream_chat_flutter/lib/src/message_widget/reactions/reaction_picker.dart
Show resolved
Hide resolved
packages/stream_chat_flutter/lib/src/message_widget/reactions/reaction_picker_icon_list.dart
Outdated
Show resolved
Hide resolved
packages/stream_chat_flutter/test/src/message_modal/moderated_message_actions_modal_test.dart
Show resolved
Hide resolved
renefloor
reviewed
May 22, 2025
packages/stream_chat_flutter/lib/src/message_modal/message_modal.dart
Outdated
Show resolved
Hide resolved
renefloor
approved these changes
May 22, 2025
xsahil03x
added a commit
that referenced
this pull request
May 26, 2025
Co-authored-by: xsahil03x <25670178+xsahil03x@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: FLU-79
Description of the pull request
This pull request combines the message actions building logic for desktop and mobile platforms by introducing a class
StreamMessageAction
to provide a reusable builder for message actions. Also introducedStreamMessageModal
for creating message related modals in the SDK.Screenshots / Videos
Screen.Recording.2025-05-13.at.17.11.41.mov