-
Notifications
You must be signed in to change notification settings - Fork 371
fix(repo): ios builds requires xcode 15 #2279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the GitHub Actions workflows for iOS-related jobs by specifying the use of the Changes
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/distribute_external.yml (1)
94-94
: Consistency: Capitalize “Xcode” in comment
For readability and alignment with Apple’s branding, update to:- runs-on: macos-15 # Requires xcode 15 or later + runs-on: macos-15 # Requires Xcode 15 or later.github/workflows/distribute_internal.yml (1)
102-102
: Consistency: Capitalize “Xcode” in comment
Align this comment with the others by using uppercase “Xcode”:- runs-on: macos-15 # Requires xcode 15 or later + runs-on: macos-15 # Requires Xcode 15 or later
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/distribute_external.yml
(1 hunks).github/workflows/distribute_internal.yml
(1 hunks).github/workflows/stream_flutter_workflow.yml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: build (ios)
- GitHub Check: build (android)
- GitHub Check: test
🔇 Additional comments (1)
.github/workflows/stream_flutter_workflow.yml (1)
156-156
: Explicit macOS runner version for iOS builds
Settingruns-on: macos-15
guarantees Xcode 15 is available for the iOS job, fulfilling the PR objective to fix iOS builds.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2279 +/- ##
==========================================
- Coverage 63.30% 63.29% -0.01%
==========================================
Files 404 404
Lines 25274 25274
==========================================
- Hits 16000 15998 -2
- Misses 9274 9276 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit