Skip to content

Conversation

@xsahil03x
Copy link
Member

@xsahil03x xsahil03x commented Jul 2, 2025

Submit a pull request

Linear: FLU-182

Description of the pull request

This PR refactors the PollMessage widget into a new PollAttachment widget and introduces a PollAttachmentBuilder.

The PollMessage widget has been removed.
The hasPoll property has been removed from MessageWidget, MessageCard, and MessageWidgetContent.
The PollAttachmentBuilder is now responsible for building poll attachments and is included in the default attachment builders.

Screenshots / Videos

Summary by CodeRabbit

  • New Features

    • Introduced a new poll attachment system, allowing polls to be displayed as attachments with customizable appearance and layout via a dedicated builder.
    • Added support for poll and voice recording attachments in the attachment system.
  • Breaking Changes

    • Replaced the previous poll message widget with the new poll attachment widget and builder. Existing poll message integrations must be updated.
  • Improvements

    • Simplified message and attachment rendering logic for better integration and customization of poll attachments.
  • Documentation

    • Updated changelog to reflect the latest changes and breaking updates.

xsahil03x added 2 commits July 2, 2025 15:58
This commit refactors the `PollMessage` widget into a new `PollAttachment` widget and introduces a `PollAttachmentBuilder`.

The `PollMessage` widget has been removed.
The `hasPoll` property has been removed from `MessageWidget`, `MessageCard`, and `MessageWidgetContent`.
The `PollAttachmentBuilder` is now responsible for building poll attachments and is included in the default attachment builders.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 2, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes refactor the poll message handling in the chat UI by removing the PollMessage widget and replacing it with a new PollAttachment widget, which integrates with the attachment system. The attachment builder system is updated to support poll attachments, and related references to poll-specific logic are removed from message widgets.

Changes

File(s) Change Summary
CHANGELOG.md Added entry for version 10.0.0-beta.3 describing the poll attachment system refactor.
lib/src/attachment/attachment.dart Exported new attachment widgets: poll_attachment.dart, voice_recording_attachment.dart, and voice_recording_attachment_playlist.dart.
lib/src/attachment/builder/attachment_widget_builder.dart, poll_attachment_builder.dart Added PollAttachmentBuilder to the default builders and updated documentation/comments.
lib/src/attachment/poll_attachment.dart Renamed and refactored PollMessage to PollAttachment with customizable shape/constraints.
lib/src/attachment/voice_recording_attachment_playlist.dart Removed unused import.
lib/src/message_widget/message_card.dart, message_widget.dart, message_widget_content.dart Removed all hasPoll logic and references; simplified attachment rendering logic.
lib/stream_chat_flutter.dart Removed export for the old poll_message.dart.
test/src/attachment/voice_recording_attachment_playlist_test.dart, voice_recording_attachment_test.dart Removed unused imports.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MessageWidget
    participant AttachmentWidgetCatalog
    participant PollAttachmentBuilder
    participant PollAttachment

    User->>MessageWidget: Sends/Views message
    MessageWidget->>AttachmentWidgetCatalog: Build attachment widgets
    AttachmentWidgetCatalog->>PollAttachmentBuilder: canHandle(message, attachments)
    PollAttachmentBuilder-->>AttachmentWidgetCatalog: true (if poll present)
    AttachmentWidgetCatalog->>PollAttachmentBuilder: build(context, message, attachments)
    PollAttachmentBuilder->>PollAttachment: Render poll UI with shape/constraints
    PollAttachment-->>User: Displays poll attachment
Loading

Assessment against linked issues

Objective (Issue) Addressed Explanation
Refactor AttachmentCatalog to support non attachment types (FLU-182)

Poem

A poll once stood alone, apart,
Now joins attachments, smart!
With shapes and bounds, it fits right in,
A builder’s touch, a brand new spin.
The catalog grows, the widgets play—
Hooray for chat, hip-hip-hooray!
🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@xsahil03x xsahil03x requested a review from renefloor July 2, 2025 14:01
@xsahil03x
Copy link
Member Author

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 2, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@codecov
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 47.05882% with 18 lines in your changes missing coverage. Please review.

Please upload report for BASE (v10.0.0@8c8dbd2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...at_flutter/lib/src/attachment/poll_attachment.dart 0.00% 11 Missing ⚠️
...rc/attachment/builder/poll_attachment_builder.dart 30.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             v10.0.0    #2296   +/-   ##
==========================================
  Coverage           ?   64.03%           
==========================================
  Files              ?      409           
  Lines              ?    25563           
  Branches           ?        0           
==========================================
  Hits               ?    16368           
  Misses             ?     9195           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xsahil03x xsahil03x merged commit 74bb460 into v10.0.0 Jul 3, 2025
7 checks passed
@xsahil03x xsahil03x deleted the refactor/attachment-catalog branch July 3, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants